Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchlight Air-Alarm Fix #1523

Merged

Conversation

Actualcatmoment
Copy link
Contributor

@Actualcatmoment Actualcatmoment commented Jun 15, 2024

About the PR

The searchlight has an incorrect air alarm configuration. This fixes it by adding the missing scrubber/vent to the network configuration.

Why / Balance

Currently the air alarm can never tell what the air quality is like in the main room of the searchlight, and the fire locks will never trigger. Also it's nice when ships don't come with issues from the shipyard.

How to test

Buy a searchlight in the current version, click on the air alarm next to the airlock, you'll notice there's a missing air vent and scrubber.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • fix: connected air vent and scrubber to the rear air alarm in the searchlight.

The searchlight has an incorrecty confirgured air alarm. This fixes it.
@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Jun 15, 2024
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jun 15, 2024
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scrubber under the generator unit is not linked

Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also don't link firelocks to air alarm

@MagnusCrowe
Copy link
Contributor

Also don't link firelocks to air alarm

Why not?

@MagnusCrowe
Copy link
Contributor

Scrubber under the generator unit is not linked

That looks intentional to me. The generator is closed away in it's own little scrubber environment, it wouldn't make much sense for the central room to flip out every time the generator releases CO2.

@Actualcatmoment
Copy link
Contributor Author

Actualcatmoment commented Jun 17, 2024

Also don't link firelocks to air alarm

I didn't. The searchlight comes like that.
Also why not? IIRC the SS14 mapping guide specifically says to remember to do so.

Secondly the one under the generator is DEFINITELY intentionally unlinked, though I suppose it could be, it would just have to have the alarm thresholds carefully tweaked to allow for the increased CO2 levels that would build up in that little box.

@MagnusCrowe
Copy link
Contributor

image
I haven't heard any complaints about it or seen this being an issue on the server while admining. I think I'm going to merge this as is. If it does become an issue, we can patch it later.

@MagnusCrowe MagnusCrowe dismissed ErhardSteinhauer’s stale review June 18, 2024 01:10

Generator scrubber is not intended to be linked and the firelocks haven't been an issue so far, they've always been linked like that.

@MagnusCrowe MagnusCrowe merged commit feca8d6 into new-frontiers-14:master Jun 18, 2024
12 checks passed
FrontierATC added a commit that referenced this pull request Jun 18, 2024
@Actualcatmoment Actualcatmoment deleted the Searchlight-Air-Alarm-Fix branch June 18, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants